Skip to content

Review src/tooltip.h comments#256

Merged
janrysavy merged 1 commit into
comments-translation-v2from
codex/tooltip-h-review
Apr 8, 2026
Merged

Review src/tooltip.h comments#256
janrysavy merged 1 commit into
comments-translation-v2from
codex/tooltip-h-review

Conversation

@janrysavy

Copy link
Copy Markdown
Owner

Summary

  • review and land the approved comment wording update in src/tooltip.h
  • keep the change strictly comment-only and aligned with the branch-target HTML review

Verification

  • node --experimental-strip-types src/cli.ts guard --target-root /mnt/d/Source/OpenSal/salamander_codex_src_20260408 --translation-source /mnt/d/Source/OpenSal/salamander_codex_src_20260408 --baseline-source /mnt/d/Source/OpenSal/salamander_upstream --artifacts-dir /mnt/d/Source/OSTranslation/artifacts/src-tooltip-h-review-20260408-run1 --file src/tooltip.h --cost-profile cheap-first --review-provider auto --copilot-model gpt-5.4 --copilot-reasoning high --prompt-log-mode full --include-audit-only
  • git -C /mnt/d/Source/OpenSal/salamander_codex_src_20260408 diff --check -- src/tooltip.h

Apply the reviewed tooltip.h comment wording from the branch-target
sequential review run.

What changed:
- updated the Show method header comment to describe the actual visible
  behavior more directly
- clarified that considerCursor moves the tooltip below the cursor
- clarified that modal mode waits for messages that close the tooltip and
  returns after the tooltip is hidden

Why it changed:
- the reviewed wording is clearer and matches the current implementation in
  tooltip.cpp without changing code behavior
- the branch-target artifacts for src/tooltip.h passed comment guard, so the
  change remains comment-only and safe to land

How the result was verified:
- inspected the reviewed patch and the tooltip implementation for semantic fit
- regenerated the triple diff HTML for the run
- ran comment guard on the delivery branch checkout and confirmed zero
  violations in strict and ignore-whitespace modes
- checked git diff and git diff --check for src/tooltip.h before committing
@janrysavy janrysavy merged commit eb282f2 into comments-translation-v2 Apr 8, 2026
3 checks passed
@janrysavy janrysavy deleted the codex/tooltip-h-review branch April 8, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants